Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview env: create two workspace classes default and small #13223

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Sep 23, 2022

Description

Create two workspace classes in the preview environment so we can test workspace classes in the preview environment.

  • Default workspace class with 30Gi disk
  • Small workspace class with 20Gi disk

image

Related Issue(s)

Related to #12638

How to test

  • Open the workspace preview.
  • Enable the feature flag PVC.
  • Open the workspace, and check the PVC size is 30Gi.
  • Change your workspace class preference to 20Gi
  • Open a new workspace, and check the PVC size is 20Gi.

Release Notes

None

Documentation

None

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@jenting
Copy link
Contributor Author

jenting commented Sep 23, 2022

/werft run

👍 started the job as gitpod-build-jenting-12638.10
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented Sep 23, 2022

We need to consider extending the default disk from 30Gi to 50Gi

harvesterhci.io/volumeClaimTemplates: '[{"metadata":{"name":"${claimName}","annotations":{"harvesterhci.io/imageId":"default/image-tfmk6"}},"spec":{"accessModes":["ReadWriteOnce"],"resources":{"requests":{"storage":"200Gi"}},"volumeMode":"Block","storageClassName":"longhorn-image-tfmk6-onereplica"}},{"metadata":{"name":"${storageClaimName}"},"spec":{"accessModes":["ReadWriteOnce"],"resources":{"requests":{"storage":"30Gi"}},"volumeMode":"Block","storageClassName":"longhorn"}}]'

Otherwise, if the developer uses the disk over 30Gi, no more data could be written into the disk.
But it also has a side effect that all the default disk sizes will increase to 50Gi.

Or, we could create a small workspace class that is smaller than 30Gi disk, for example, 20Gi, since it's for testing purposes.

WDYT? @gitpod-io/platform

@jenting jenting marked this pull request as ready for review September 23, 2022 07:09
@jenting jenting requested a review from a team September 23, 2022 07:10
@jenting
Copy link
Contributor Author

jenting commented Sep 25, 2022

/werft run

👍 started the job as gitpod-build-jenting-12638.15
(with .werft/ from main)

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could create a small workspace class that is smaller than 30Gi disk, for example, 20Gi, since it's for testing purposes.

@jenting I'd prefer the suggestion of using smaller classes and then keeping the storage definition at "30Gi". We could even go as low as 10gb and 20gb for the workspace classes as I don't expect people to run any workspaces larger than that in preview environments ☺️

I added the hold label and I'm approving so you can merge once you've that change ☺️

Default workspace class with 30Gi disk
Small workspace class with 20Gi disk

Signed-off-by: JenTing Hsiao <[email protected]>
@jenting jenting changed the title preview env: create two workspace classes default and large preview env: create two workspace classes default and small Sep 27, 2022
@jenting
Copy link
Contributor Author

jenting commented Sep 27, 2022

we could create a small workspace class that is smaller than 30Gi disk, for example, 20Gi, since it's for testing purposes.

@jenting I'd prefer the suggestion of using smaller classes and then keeping the storage definition at "30Gi". We could even go as low as 10gb and 20gb for the workspace classes as I don't expect people to run any workspaces larger than that in preview environments ☺️

I added the hold label and I'm approving so you can merge once you've that change ☺️

Thank you @mads-hartmann

I change to using a smaller workspace class where the disk size is 20G.
I have updated the code.

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants