Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last tidying around https://github.com/gitpod-io/gitpod/issues/12964 #13184

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

mrzarquon
Copy link
Contributor

Typos in policy declarations

[AWS Infra] Terraform code updated to create correct policies for S3 buckets

Description

Third times a charm?

Typos in policy declarations

```release-note
[AWS Infra] Terraform code updated to create correct policies for S3 buckets
```
@mrzarquon mrzarquon requested a review from a team September 21, 2022 15:31
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 21, 2022
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sagor999
Copy link
Contributor

/hold
build is failing and blocking tide

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Sep 22, 2022

/werft run

👍 started the job as gitpod-build-mrz-fix-s3-more.1
(with .werft/ from main)

@mrsimonemms
Copy link
Contributor

@sagor999 rerunning the Werft build and it now passes the test. It looks like the Yarn package failed to publish (not changed as part of this PR)

/unhold

@roboquat roboquat merged commit 033e178 into main Sep 22, 2022
@roboquat roboquat deleted the mrz/fix_s3_more branch September 22, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XS team: delivery Issue belongs to the self-hosted team
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants