Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuration of core dump behavior #13144

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Enable configuration of core dump behavior #13144

merged 3 commits into from
Sep 21, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 20, 2022

Description

By default, core dumps are disabled. If we want to enable the feature, we need to update the .gitpod.yml file

coreDump:
  enabled: true

Optionally we can set custom sizes

coreDump:
  enabled: true
  softLimit: <bytes>
  hardLimit: <bytes>

Related Issue(s)

Replaces #12814
Fixes #12453

How to test

Tests:


  1. Default behavior

  1. Enable core dumps

  1. Enable core dumps with custom sizes

Release Notes

NONE

Documentation

xref https://github.com/gitpod-io/website/pull/2767

Werft options:

  • /werft with-preview

@aledbf aledbf changed the title Aledbf/core Enable configuration of core dump behavior Sep 20, 2022
@aledbf aledbf force-pushed the aledbf/core branch 4 times, most recently from 1761dcd to f8333b7 Compare September 21, 2022 00:13
@aledbf aledbf marked this pull request as ready for review September 21, 2022 00:41
@aledbf aledbf requested review from a team September 21, 2022 00:41
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Sep 21, 2022
@david-bakin
Copy link

Thanks for doing this properly, i.e., by adding per-repo user configuration.

@aledbf aledbf force-pushed the aledbf/core branch 3 times, most recently from b8d4ae0 to e2325e1 Compare September 21, 2022 11:21
@csweichel
Copy link
Contributor

cc @svenefftinge PTAL

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides some small things

/hold

components/workspacekit/cmd/rings.go Show resolved Hide resolved
components/gitpod-protocol/src/protocol.ts Outdated Show resolved Hide resolved
@aledbf aledbf force-pushed the aledbf/core branch 2 times, most recently from d36cde4 to 499884f Compare September 21, 2022 13:43
@aledbf
Copy link
Member Author

aledbf commented Sep 21, 2022

/werft run

👍 started the job as gitpod-build-aledbf-core.16
(with .werft/ from main)

@roboquat roboquat merged commit 746798f into main Sep 21, 2022
@roboquat roboquat deleted the aledbf/core branch September 21, 2022 14:43
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 22, 2022
@atduarte
Copy link
Contributor

@aledbf FYI replace release notes with a multi-line release note here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace Cluttered with core.* files
8 participants