-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configuration of core dump behavior #13144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
release-note
do-not-merge/work-in-progress
size/M
size/L
and removed
size/M
labels
Sep 20, 2022
aledbf
force-pushed
the
aledbf/core
branch
4 times, most recently
from
September 21, 2022 00:13
1761dcd
to
f8333b7
Compare
github-actions
bot
added
team: webapp
Issue belongs to the WebApp team
team: workspace
Issue belongs to the Workspace team
labels
Sep 21, 2022
utam0k
approved these changes
Sep 21, 2022
david-bakin
reviewed
Sep 21, 2022
Thanks for doing this properly, i.e., by adding per-repo user configuration. |
aledbf
force-pushed
the
aledbf/core
branch
3 times, most recently
from
September 21, 2022 11:21
b8d4ae0
to
e2325e1
Compare
cc @svenefftinge PTAL |
svenefftinge
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides some small things
/hold
aledbf
force-pushed
the
aledbf/core
branch
2 times, most recently
from
September 21, 2022 13:43
d36cde4
to
499884f
Compare
/werft run 👍 started the job as gitpod-build-aledbf-core.16 |
roboquat
added
deployed: webapp
Meta team change is running in production
deployed: workspace
Workspace team change is running in production
deployed
Change is completely running in production
labels
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: webapp
Meta team change is running in production
deployed: workspace
Workspace team change is running in production
deployed
Change is completely running in production
release-note-none
size/L
team: webapp
Issue belongs to the WebApp team
team: workspace
Issue belongs to the Workspace team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, core dumps are disabled. If we want to enable the feature, we need to update the .gitpod.yml file
Optionally we can set custom sizes
Related Issue(s)
Replaces #12814
Fixes #12453
How to test
Tests:
ulimit -c
and check the value is 0sleep 900&
kill -s SIGSEGV [pid]
core.*
file existulimit -c
and check the value is 1048576echo $GITPOD_RLIMIT_CORE
is{"softLimit":1073741824,"hardLimit":1073741824}
sleep 900&
kill -s SIGSEGV [pid]
core.[pid]
existsulimit -c
and check the value is 9765echo $GITPOD_RLIMIT_CORE
is{"soft-limit":10000000,"hard-limit":20000000}
sleep 900&
kill -s SIGSEGV [pid]
core.[pid]
exists and size is about393216
Release Notes
Documentation
xref https://github.com/gitpod-io/website/pull/2767
Werft options: