[terraform/aks] Implement separate nodepool types, node pool max sizes, machine types #13143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienthebo
added
component: install
|
I realized since these nodegroups are getting created in different resource groups, it shouldn't matter. Also, that is how it has always been. /hold for test to pass https://werft.gitpod-dev.com/job/gitpod-custom-alt-terraform-headless-ws-aks.0 |
nandajavarma
approved these changes
Sep 27, 2022
adrienthebo
force-pushed
the
alt/terraform/headless-ws/aks
branch
from
70d700e to
b932fd7
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…orkspaces, and headless-workspaces
adrienthebo
force-pushed
the
alt/terraform/headless-ws/aks
branch
from
b932fd7 to
3afb150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request breaks up the AKS workloads into separate services, regular workspace, and headless workspace node pools. It also plumbs through machine type and node pool max instance counts.
Related Issue(s)
See #12740
How to test
Create a self-hosted preview with werft:
Then configure the git integration, run a workspace, and ensure that imagebuilds/regular workspaces run on separate nodes.
Release Notes
Documentation
Werft options:
Valid options are
all,workspace,webapp,ide