[terraform/gcp] Split up regular and headless workspaces into separate nodepools #13140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
install/infra/modules/gke/cluster.tf
Outdated
| resource "google_container_node_pool" "workspaces" { | ||
| name = "workspaces-${var.cluster_name}" | ||
| resource "google_container_node_pool" "regular-workspaces" { | ||
| name = "regular-workspaces-${var.cluster_name}" |
There was a problem hiding this comment.
Just wondering if this reduces the maximum length allowed for cluster_name
There was a problem hiding this comment.
Hmm, likely - we can trim this down a bit. Good call!
nandajavarma
approved these changes
Sep 27, 2022
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
See #12740
How to test
Create a preview environment with werft:
Once the preview is up, login to the node and confirm that image builds run on headless workspace nodes and workspaces run on regular-workspace nodes.
Release Notes
Documentation
Werft options:
Valid options are
all,workspace,webapp,ide