[usage] Enable usage view with feature flag #13065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-se-usage-view.38 because the annotations in the pull request description changed |
|
/werft run 👍 started the job as gitpod-build-se-usage-view.39 |
svenefftinge
force-pushed
the
se/usage-view
branch
from
751d56c to
2807a77
Compare
easyCZ
reviewed
Sep 21, 2022
Comment on lines
+41
to
+45
| const featureFlags: FeatureFlagConfig = { | ||
| workspace_classes: { defaultValue: true, setter: setShowWorkspaceClassesUI }, | ||
| persistent_volume_claim: { defaultValue: true, setter: setShowPersistentVolumeClaimUI }, | ||
| usage_view: { defaultValue: true, setter: setShowUsageView }, | ||
| }; |
There was a problem hiding this comment.
What's the reason for making these very explicit (rather than reflecting over the set of flags)? I feel this has the potential to confuse others who are trying to use feature flags - having to define them here.
There was a problem hiding this comment.
Ah never mind, I missed that you just moved the definition (and the problem already exists)
jldec
approved these changes
Sep 21, 2022
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we have discoupled "usage" from stripe now, we can allow all users to use the usage view in order to understand how they use Gitpod (and where their hours go). This is also helpful to get a forecast of how many credits I'd need next month in case I want to switch to usage-based pricing.
This change enabled the usage view for everyone (depending on a feature flag, which is currently disabled for everyone in prod).
Related Issue(s)
Fixes #
How to test
Login to the preview environment and see usage view on your individual account and all team accounts.
Release Notes
Documentation
Werft options: