fix: improve GoLang config inferrer #13057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run go command at current (root) Signed-off-by: Siddhant Khare <[email protected]>
svenefftinge
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Thanks and sorry for the delay! I was hesitant as we generally need to revisit this. go get is deprecated and implied by go build. Maybe adding go generate ./... would make sense as well and passing ./... instead of just . to everything. But your change doesn't seem to make it worse so let's apply it. 👍
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, it runs
go runwhich doesn't work. (example repo used). But it does, work withgo run .(see below 👀)you can test out the same for other goLang based repos
How to test
Release Notes
Documentation
Not Required
Werft options:
Signed-off-by: Siddhant Khare [email protected]