Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove global S3 access policy #12965

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix: remove global S3 access policy #12965

merged 1 commit into from
Sep 14, 2022

Conversation

mrzarquon
Copy link
Contributor

@mrzarquon mrzarquon commented Sep 14, 2022 •
edited
Loading

Description

Fixes #12964

We no longer need to attach these policies to the S3 users we create in our terraform modules.

No longer attaches `arn:aws:iam::aws:policy/AmazonS3FullAccess` to the IAM user accounts created in our AWS terraform reference infrastructure. This level of access is no longer required now that one can provide an S3 bucket to be used for object storage.

@mrzarquon mrzarquon requested a review from a team September 14, 2022 13:31
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team and removed size/S labels Sep 14, 2022
@roboquat roboquat merged commit 8ad49ab into main Sep 14, 2022
@roboquat roboquat deleted the mrz/fix_s3 branch September 14, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsimonemms mrsimonemms mrsimonemms approved these changes

Assignees
No one assigned
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
No open projects
🚚 Security, Infrastructure, and Delivery Team (SID)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS Terraform Ref Arch is too permissive
3 participants
@mrzarquon @mrsimonemms @roboquat