Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Every time we stop a workspace instance, log the reason why #12963

Merged
merged 1 commit into from
Sep 16, 2022
Merged

[server] Every time we stop a workspace instance, log the reason why #12963

merged 1 commit into from
Sep 16, 2022

Conversation

jankeromnes
Copy link
Contributor

Description

Every time we stop a workspace instance, log the reason why. This should help with debugging.

Related Issue(s)

Fixes #12283

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Sep 14, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jx-log-stop-reason.1
(with .werft/ from main)

@jankeromnes jankeromnes marked this pull request as ready for review September 15, 2022 08:49
@jankeromnes jankeromnes requested a review from a team September 15, 2022 08:49
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 15, 2022
geropl
geropl approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @jankeromnes , LGTM.

/hold In case you want to tackle the nits, and to give @sagor999 the possibility to review as well.

sagor999
sagor999 approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Sep 16, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks for the reviews!

Nits addressed, go for launch 🚀

/unhold

@roboquat roboquat merged commit 3ac0c02 into main Sep 16, 2022
@roboquat roboquat deleted the jx/log-stop-reason branch September 16, 2022 06:06
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server: please log any call to StopWorkspace with the reason why it is called
4 participants
@jankeromnes @sagor999 @geropl @roboquat