[local-preview] Reduce storage requirements #12761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reduces the storage requests across PVC's and workspaces Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
commented
Sep 8, 2022
| @@ -181,6 +181,9 @@ yq e -i '.customCACert.kind = "secret"' config.yaml | |||
| yq e -i '.observability.logLevel = "debug"' config.yaml | |||
| yq e -i '.workspace.runtime.containerdSocket = "/run/k3s/containerd/containerd.sock"' config.yaml | |||
| yq e -i '.workspace.runtime.containerdRuntimeDir = "/var/lib/rancher/k3s/agent/containerd/io.containerd.runtime.v2.task/k8s.io/"' config.yaml | |||
| yq e -i '.workspace.pvc.size = "10Gi"' config.yaml | |||
| yq e -i '.workspace.resources.requests.memory = "500Mi"' config.yaml | |||
There was a problem hiding this comment.
Is this too less? I've opened a couple of workspaces and got a good moving around experience in the browser but I'm sure it could be a bottleneck if the user tries to do more i.e run things, etc.
There was a problem hiding this comment.
Since we're dealing with memory requests and not limits this should be fine; it's unlikely that a user will be running that many workspaces and will be totally saturating memory. LGTM!
adrienthebo
approved these changes
Sep 10, 2022
|
@Pothulapati is this still being held? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the storage requests across PVC's, control-plane components
and workspaces storage.
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Part of #11303
How to test
Run
Release Notes
Documentation
Werft options: