Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gitpod-related actions to JetBrains IDEs #12621

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Add Gitpod-related actions to JetBrains IDEs #12621

merged 1 commit into from
Sep 8, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Sep 2, 2022 •
edited by andreafalzetti
Loading

Description

Add Gitpod-related actions to JetBrains IDEs, similar to the ones from VS Code.

Actions in Control Center Actions in Search Menu
image Screenshot 2022-09-07 at 15 59 57
Sorted by relevance. We define the order. Sorted alphabetically. IntelliJ defines the order.

Actions added:

  • Open Dashboard
  • Open Context
  • Open Settings
  • Open Access Control
  • Documentation
  • Report Issue
  • Follow Us On Twitter
  • Open Community Chat
  • Upgrade Subscription
  • Stop Workspace
  • Extend Workspace Timeout
  • Share Workspace Snapshot

Actions out of scope:

  • Open in Browser (requires indicator in supervisor frontend to avoid re-opening the IDE)
  • Share Running Workspace (currently not supported)

Related Issue(s)

How to test

  • Start a workspace: https://felladrin-6e3aa70a7f.preview.gitpod-dev.com/#https://github.com/gitpod-io/spring-petclinic
  • Select any JetBrains IDE (it can be Stable or EAP).
  • Open the control center and click the three-dot icon to open the Actions Menu.
  • Confirm if the Gitpod actions displayed there work properly by clicking in all of them.
    Screenshot 2022-09-07 at 15 58 57
  • Check if the analytics events are received, as you click the actions.
  • Double-press Shift key to open the Search Menu, and confirm if searching for "Gitpod: " returns displays all the actions.
    image
  • Confirm if the Release Note in this PR is expressing this change accordingly.

Release Notes

JetBrains IDEs now have actions related to Gitpod, which can be accessed via Control Center and via the Search Menu.

Werft options:

  • /werft with-preview
  • /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@felladrin felladrin self-assigned this Sep 2, 2022
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Sep 2, 2022
@felladrin
Copy link
Contributor Author

I've tested it on the Preview Environment and it's working as expected. So I'm now marking it as Ready for Review.

image

image

@felladrin felladrin marked this pull request as ready for review September 2, 2022 14:59
@felladrin felladrin requested a review from a team September 2, 2022 14:59
@felladrin felladrin force-pushed the felladrin/jetbrains-add-actions-8024 branch from fdae431 to 4195eb0 Compare September 3, 2022 10:10
@felladrin felladrin force-pushed the felladrin/jetbrains-add-actions-8024 branch from 4195eb0 to 690ccaf Compare September 3, 2022 10:20
@andreafalzetti andreafalzetti force-pushed the felladrin/jetbrains-add-actions-8024 branch from 690ccaf to 1563a25 Compare September 5, 2022 10:49
@andreafalzetti andreafalzetti force-pushed the felladrin/jetbrains-add-actions-8024 branch from 1563a25 to ecede7c Compare September 5, 2022 20:50
@andreafalzetti andreafalzetti marked this pull request as draft September 6, 2022 19:22
@andreafalzetti andreafalzetti force-pushed the felladrin/jetbrains-add-actions-8024 branch from ecede7c to ec8016a Compare September 6, 2022 19:23
@roboquat roboquat added size/XXL and removed size/XL labels Sep 6, 2022
@andreafalzetti andreafalzetti force-pushed the felladrin/jetbrains-add-actions-8024 branch from ec8016a to 7ebeabc Compare September 6, 2022 19:25
@roboquat roboquat added size/XL and removed size/XXL labels Sep 6, 2022
@andreafalzetti andreafalzetti force-pushed the felladrin/jetbrains-add-actions-8024 branch from 7ebeabc to 4d35821 Compare September 6, 2022 20:56
@roboquat roboquat added size/XXL and removed size/XL labels Sep 6, 2022
@andreafalzetti andreafalzetti force-pushed the felladrin/jetbrains-add-actions-8024 branch 2 times, most recently from 72ccf41 to 705f664 Compare September 7, 2022 14:23
@andreafalzetti andreafalzetti marked this pull request as ready for review September 7, 2022 14:54
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Sep 7, 2022
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Sep 7, 2022
@andreafalzetti
Copy link
Contributor

andreafalzetti commented Sep 7, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-felladrin-jetbrains-add-actions-8024.22
(with .werft/ from main)

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Sep 7, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-felladrin-jetbrains-add-actions-8024.23
(with .werft/ from main)

@akosyakov
Copy link
Member

akosyakov commented Sep 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-felladrin-jetbrains-add-actions-8024.24
(with .werft/ from main)

@andreafalzetti andreafalzetti force-pushed the felladrin/jetbrains-add-actions-8024 branch from 705f664 to b1d585c Compare September 8, 2022 08:34
akosyakov
akosyakov approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as advertised and code looks good

/hold

@andreafalzetti please unhold when you are ready

@andreafalzetti andreafalzetti force-pushed the felladrin/jetbrains-add-actions-8024 branch from b1d585c to 6b28f5f Compare September 8, 2022 13:43
@andreafalzetti
Copy link
Contributor

andreafalzetti commented Sep 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-felladrin-jetbrains-add-actions-8024.28
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-felladrin-jetbrains-add-actions-8024.27 because the annotations in the pull request description changed
(with .werft/ from main)

@andreafalzetti andreafalzetti force-pushed the felladrin/jetbrains-add-actions-8024 branch from 6b28f5f to 3974e5d Compare September 8, 2022 17:04
@andreafalzetti andreafalzetti force-pushed the felladrin/jetbrains-add-actions-8024 branch from 3974e5d to 146e2e0 Compare September 8, 2022 17:21
@andreafalzetti
Copy link
Contributor

I've updated the order to reflect the data-driven order and also aligned the event name for opening URLs with VS Code.

/unhold

@roboquat roboquat merged commit a794d7f into main Sep 8, 2022
@roboquat roboquat deleted the felladrin/jetbrains-add-actions-8024 branch September 8, 2022 18:02
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreafalzetti andreafalzetti andreafalzetti left review comments

@akosyakov akosyakov akosyakov approved these changes

Assignees

@felladrin felladrin

@andreafalzetti andreafalzetti

Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/XXL team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felladrin @andreafalzetti @akosyakov @roboquat