Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels to PVC and VolumeSnapshot object #12536

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Add labels to PVC and VolumeSnapshot object #12536

merged 3 commits into from
Aug 31, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Aug 31, 2022

Description

Add more labels to PVC and VolumeSnapshot, so we have more information to troubleshoot/debug to know the VolumeSnapshot belonged to which workspace ID when the workspace pod was gone.
Also, we could find the workspace ID if the PVC keeps in Pending but somehow the workspace pod was gone.

Related Issue(s)

Fixes #12507

How to test

  • Enable PVC feature flag in preview env
  • Launch a workspace
  • Check the PVC with labels kubectl get pvc --show-labels
  • Stop the workspace
  • Check the VolumeSnapshot with labels kubectl get vs --show-labels

Release Notes

None

Documentation

Werft options:

  • /werft with-preview

@jenting
Add labels to PVC object
cb9c6fc 
Signed-off-by: JenTing Hsiao <[email protected]>
@jenting jenting marked this pull request as ready for review August 31, 2022 05:45
@jenting jenting requested a review from a team August 31, 2022 05:45
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 31, 2022
@jenting jenting marked this pull request as draft August 31, 2022 05:46
jenting added 2 commits August 31, 2022 05:48
@jenting
Add labels to VolumeSnapshot object
1d6196e 
Signed-off-by: JenTing Hsiao <[email protected]>
@jenting
Update golden files
7306b2b 
Signed-off-by: JenTing Hsiao <[email protected]>
@jenting jenting force-pushed the jenting/pvc-propagate-workspace-12507 branch from db99c94 to 7306b2b Compare August 31, 2022 05:49
@jenting jenting marked this pull request as ready for review August 31, 2022 06:07
@roboquat roboquat merged commit df7af28 into main Aug 31, 2022
@roboquat roboquat deleted the jenting/pvc-propagate-workspace-12507 branch August 31, 2022 14:08
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Furisto Furisto Furisto approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PVC] Propagate workspace pod labels to PVC and VolumeSnapshot
3 participants
@jenting @Furisto @roboquat