Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[supervisor] support ssh gateway on not gitpod base image #12498

Merged
merged 1 commit into from
Aug 30, 2022
Merged

[supervisor] support ssh gateway on not gitpod base image #12498

merged 1 commit into from
Aug 30, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Aug 30, 2022 •
edited
Loading

Description

[supervisor] support ssh gateway on not gitpod base image

In gitpod base docker image, we write HOME environment, but if user use none gitpod base image, the HOME environment is not set or set other value, which causes public key didn't write in correct path

not gitpod base image gitpod base image
image image

This PR change use hard code /home/gitpod as HOME dir

Related Issue(s)

Fixes #12265
Fixes #12143

How to test

  1. open this example repo in preview environment https://github.com/spring-projects/spring-petclinic
  2. connect to workspace via ssh gateway (copy/paste ssh command or upload your public key)
  3. it should be connected

Release Notes

[supervisor] support ssh gateway on not gitpod base image

Documentation

Werft options:

  • /werft with-preview

@iQQBot iQQBot self-assigned this Aug 30, 2022
@iQQBot iQQBot marked this pull request as ready for review August 30, 2022 06:16
@iQQBot iQQBot requested a review from a team August 30, 2022 06:16
mustard-mh
mustard-mh reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, going to test it

mustard-mh
mustard-mh approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Tested and it works well

@roboquat roboquat merged commit 1a65e69 into main Aug 30, 2022
@roboquat roboquat deleted the pd/fix-12265 branch August 30, 2022 06:43
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustard-mh mustard-mh mustard-mh approved these changes

Assignees

@iQQBot iQQBot

Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/S team: IDE
Projects
None yet
Milestone
No milestone
3 participants
@iQQBot @mustard-mh @roboquat