Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[local-preview] Remove unused dead code #12496

Merged
merged 1 commit into from
Sep 7, 2022
Merged

[local-preview] Remove unused dead code #12496

merged 1 commit into from
Sep 7, 2022

Conversation

Pothulapati
Copy link
Contributor

Description

This PR removes the unnecessary dead code in the
entrypoint.sh that isn't actually useful anymore,
or become stale.

Signed-off-by: Tarun Pothulapati [email protected]

Related Issue(s)

Fixes #

How to test

Release Notes

[local-preview] Remove unused dead code

Documentation

Werft options:

  • /werft with-preview

@Pothulapati Pothulapati requested a review from a team August 30, 2022 03:44
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Aug 30, 2022
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Happy to approve as looks ok, but have no way of testing. Feel free to remove the hold, or wait for someone with an M1 Mac who can test

@Pothulapati Pothulapati force-pushed the tar/code-cleanup branch 2 times, most recently from d893f78 to 0fd268b Compare September 7, 2022 07:45
This PR removes the unnecessary dead code in the
`entrypoint.sh` that isn't actually useful anymore,
or become stale.

Signed-off-by: Tarun Pothulapati <[email protected]>

update k3s image

Signed-off-by: Tarun Pothulapati <[email protected]>
@roboquat roboquat merged commit 470c1eb into main Sep 7, 2022
@roboquat roboquat deleted the tar/code-cleanup branch September 7, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants