Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content-service: fix incorrect user:group after git operation #12422

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Aug 26, 2022

Description

  • Revert the 32a0f89
  • Fix the files user:group is root:gitpod after git checkout operation.

Related Issue(s)

Fixes #12420

How to test

  • Open preview env and enable the PVC feature flag
  • Launch a workspace by PR
  • Check all the files and directories under .git/ folder, the user:group is gitpod:gitpod

Release Notes

experimental: enable the feature flag PVC, the files/folders under .git/ folder user:group permission is incorrect

Documentation

Werft options:

  • /werft with-preview

@jenting jenting requested a review from a team August 26, 2022 03:09
@jenting jenting marked this pull request as draft August 26, 2022 03:09
@jenting jenting force-pushed the revert-12238-pavel/supervisor-pvc branch from 3205d3a to 6530f90 Compare August 26, 2022 06:51
@roboquat roboquat added size/M and removed size/S labels Aug 26, 2022
@jenting jenting force-pushed the revert-12238-pavel/supervisor-pvc branch from a8920eb to 2cacbb3 Compare August 26, 2022 07:27
@roboquat roboquat added size/S and removed size/M labels Aug 26, 2022
@jenting jenting changed the title Revert "[supervisor] fix chown of /workspace when using PVC" [supervisor] fix chown of /workspace when using PVC Aug 26, 2022
@roboquat roboquat added size/XS and removed size/S labels Aug 26, 2022
@jenting jenting force-pushed the revert-12238-pavel/supervisor-pvc branch from 324a46c to 5716331 Compare August 26, 2022 08:04
@jenting jenting changed the title [supervisor] fix chown of /workspace when using PVC content-service: fix incorrect user:group after git checkout operation Aug 26, 2022
@roboquat roboquat added size/S and removed size/XS labels Aug 26, 2022
@jenting jenting marked this pull request as ready for review August 26, 2022 08:22
@jenting jenting requested a review from a team August 26, 2022 08:22
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 26, 2022
@jenting jenting changed the title content-service: fix incorrect user:group after git checkout operation content-service: fix incorrect user:group after git operation Aug 26, 2022
@andreafalzetti
Copy link
Contributor

@jenting how can I enable the PVC feature flag?

@jenting
Copy link
Contributor Author

jenting commented Aug 26, 2022

@jenting how can I enable the PVC feature flag?

I enable your account PVC feature flag and set you as an admin https://revert-12242a69fdec6.preview.gitpod-dev.com/

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-revert-12238-pavel-supervisor-pvc.23 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh
Copy link
Contributor

I'm going to test it in prev env

@jenting
Copy link
Contributor Author

jenting commented Aug 26, 2022

I'm going to test it in prev env

I enable your account PVC feature flag and set you as an admin https://revert-12242a69fdec6.preview.gitpod-dev.com/

Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as advertised in prev env

drwxr-sr-x  8 gitpod gitpod 4096 Aug 26 10:19 ./
drwxr-sr-x  3 gitpod gitpod 4096 Aug 26 10:19 ../
drwxr-sr-x  2 gitpod gitpod 4096 Aug 26 10:19 branches/
-rw-r--r--  1 gitpod gitpod  279 Aug 26 10:19 config
-rw-r--r--  1 gitpod gitpod   73 Aug 26 10:19 description
-rw-r--r--  1 gitpod gitpod  114 Aug 26 10:19 FETCH_HEAD
-rw-r--r--  1 gitpod gitpod   21 Aug 26 10:19 HEAD
drwxr-sr-x  2 gitpod gitpod 4096 Aug 26 10:19 hooks/
-rw-r--r--  1 gitpod gitpod  225 Aug 26 10:19 index
drwxr-sr-x  2 gitpod gitpod 4096 Aug 26 10:19 info/
drwxr-sr-x  3 gitpod gitpod 4096 Aug 26 10:19 logs/
drwxr-sr-x 23 gitpod gitpod 4096 Aug 26 10:19 objects/
-rw-r--r--  1 gitpod gitpod  112 Aug 26 10:19 packed-refs
drwxr-sr-x  5 gitpod gitpod 4096 Aug 26 10:19 refs/

/hold

waiting for @mustard-mh to finish her review

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and code LGTM

/unhold

image

@roboquat roboquat merged commit fab72bc into main Aug 26, 2022
@roboquat roboquat deleted the revert-12238-pavel/supervisor-pvc branch August 26, 2022 12:35
@sagor999
Copy link
Contributor

Nice!!! ❤️

@roboquat roboquat added the deployed: IDE IDE change is running in production label Aug 29, 2022
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/S team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PVC] the files and folders under .git/ permission is incorrect
6 participants