[server] 'abort' prebuilds #12386
Merged
[server] 'abort' prebuilds #12386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @svenefftinge , #12284 is deployed now, so if you wanted to proceed with this from a webapp standpoint, that woudl be doable. cc: @sagor999 for posterity |
use the new StopWorkspacePolicy introduced with #12284 to avoid spending resources on backing up discarded prebuilds.
svenefftinge
force-pushed
the
sefftinge/calling-stopworkspace-11453
branch
from
1aab8ba to
a468dad
Compare
svenefftinge
commented
Sep 6, 2022
| { span }, | ||
| instance.id, | ||
| instance.region, | ||
| StopWorkspacePolicy.ABORT, |
There was a problem hiding this comment.
The main change is, to use this new policy which makes ws-manager not care about backups.
andrew-farries
approved these changes
Sep 6, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
StopWorkspacePolicy.ABORTEDintroduced with #12284 to avoidspending resources on backing up discarded prebuilds.
Related Issue(s)
Fixes #11453
Release Notes
Werft options: