-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gp-cli] provide workspace class info in top command #12338
Conversation
started the job as gitpod-build-mustard-mh-gp-cli-gp-command-to-10572.1 because the annotations in the pull request description changed |
How can users know their workspace's limit(show in command? or in document)? How to ask if they want to upgrade their plan (when CPU/MEM is nearly full?) i.e.
|
For comment #12338 (comment) above |
I don't think we need to ask. Maybe just add a link to the plan page for now? cc @loujaybee |
8fd8d7e
to
ef7ea8d
Compare
0d2d237
to
2e73822
Compare
7ed537f
to
afadaf5
Compare
Thanks for pointing this out, Huiwen. I am having some issues with the command you mentioned but I don't think it matters, it makes sense in how you implemented this. |
@Furisto Could you review it please? |
114bd2d
to
6f57d80
Compare
Fource push to
See diff here |
6f57d80
to
5b3c843
Compare
5b3c843
to
871fc46
Compare
I think it is important for people to know why they have such limits. I don't see one line as a bloat. |
@akosyakov touché. I meant with it that I personally would not find this much useful, and a one-off command like mentioned in #10572 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mustard-mh You can unhold it? |
/unhold |
@gitpod-io/engineering-webapp Could someone review this PR? |
Description
Show workspace class info in
gp top
command, support--json
flagRelated Issue(s)
Fixes #10572
How to test
gp top
andgp top --json
to see if workspace class displayedRelease Notes
Documentation
Werft options: