Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots]: give installer same node affinity as ws-daemon #12227

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Aug 19, 2022

Description

As we're auto-detecting the containerd location in the installer job, we should be on a "workspace" node so this ensures that the installer job is run on the correct node.

This is an edge case and not one we've yet been caught by, but it's possible that the nodes are configured differently (as with SaaS) so it's something I think we should do.

How to test

Install via KOTS.

Release Notes

[kots]: give installer same node affinity as ws-daemon

Documentation

Werft options:

  • /werft with-preview

As we're auto-detecting the containerd location in the installer job,
we must be on a "workspace" node so this ensures that the installer job
is run on the correct node.
@mrsimonemms mrsimonemms marked this pull request as ready for review August 19, 2022 10:08
@mrsimonemms mrsimonemms requested a review from a team August 19, 2022 10:08
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Aug 19, 2022
Copy link
Contributor

@nandajavarma nandajavarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roboquat roboquat merged commit faa792a into main Aug 23, 2022
@roboquat roboquat deleted the sje/kots-installer-job-affinity branch August 23, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants