-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JetBrains] Show Workspace CPU/Memory resources in control center #12053
[JetBrains] Show Workspace CPU/Memory resources in control center #12053
Conversation
started the job as gitpod-build-afalz-10580-show-workspace-metrics-in-jb-cont.5 because the annotations in the pull request description changed |
components/ide/jetbrains/backend-plugin/src/main/resources-latest/META-INF/extensions.xml
Outdated
Show resolved
Hide resolved
...kend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/latest/GitpodMetricControlProvider.kt
Outdated
Show resolved
Hide resolved
...kend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/latest/GitpodMetricControlProvider.kt
Outdated
Show resolved
Hide resolved
229bb41
to
9fd020e
Compare
9fd020e
to
54bdfeb
Compare
54bdfeb
to
63693d6
Compare
...nts/ide/jetbrains/backend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/GitpodManager.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code wise it looks good, but i did not try, i wanted but it was pretty slow, probably someone else already trying :D
/hold
hold just in case if someone wants to try or Andrea wants to address something else
I think it should be aligned with default of standard tools like |
For me, it's also nicer to have it in "GB". |
ℹ️ I'm reviewing it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @felladrin and @akosyakov 🙌 /unhold |
let's go with |
Context
Currently, in JetBrains IDE the CPU/Memory usage displayed applies to the whole node, instead of displaying the workspace's specific resources.
Description
With this PR we introduce two additional progress bars at the top displaying:
Workspace CPU
Workspace Memory
Please note: The Unit used for Memory resource is on purpose "GB" instead of "Mi" like in
gitpod-cli
, my reasons:0.38GB / 1.55GB
instead of2944Mi/11870Mi
Mi
I would actually like to propose a separate issue to change it also in
gp top
but I would like to know if there are any reasons or string objections in favor of the smaller unit. cc @akosyakov @felladrinRelated Issue(s)
Fixes #10580
How to test
IntelliJ
+Latest Release (Unstable)
as your preferred IDEOPTIONAL:
yes > /dev/null &
multiple times, observe the progress bar growing and moving to Warning and Danger.killall yes
cat /dev/zero | head -c 5G | tail
once or twice, and observe the memory progress bar behaving as expectedRelease Notes
Documentation
Werft options: