[installer]: use typemeta declaration in the helm customisations #12031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/installer-helm-customize
branch
from
b236aed to
6b4069b
Compare
github-actions
bot
added
the
team: delivery
nandajavarma
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spotting an error in the Helm customisations where the
typeMetavariable wasn't being passed through to the annotations and was using the Deployment instead. This was spotted whilst trying to add an annotation to the in-cluster database statefulset, so a render test has been added to that effect.This changes to using the correct variable instead.
How to test
See Golden files
Release Notes
Documentation
Werft options: