Update the alert description unit #11980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JenTing Hsiao <[email protected]>
github-actions
bot
added
team: webapp
andrew-farries
approved these changes
Aug 9, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the alert description unit, it should be second(s), not millisecond(ms).
gitpod/operations/observability/mixins/meta/rules/components/server/alerts.libsonnet
Line 27 in 9329cb6
The alert displays
description = Server has accumulated 0.36 ms event loop lag.However, the Grafana dashboard max/avg/current is around 2xx ms
Therefore, we change the unit to second.
Related Issue(s)
Fixes #
How to test
N/A
Release Notes
Documentation
N/A
Werft options: