-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: remove the custom labels from the selector labels #11954
Conversation
ff63f30
to
e98f595
Compare
This is blocked by Go formatting issues, which is being fixed in #11958 |
e98f595
to
48f229b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for making this change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me.
Would be a good opportunity to add a test (basically a *.golden file with the result of the config you added in the PR description). What do you think?
/hold in case you want to add this
@corneliusludmann a very good idea, I'll do that |
48f229b
to
186c373
Compare
/unhold |
Description
Remove a limitation on the custom labels by removing the customisation on the selector labels. These are "reverted" to just using the default labels function instead so they're consistent.
Related Issue(s)
Fixes #11952
How to test
Deploy via KOTS.
All of these should install fine.
Release Notes
Documentation
Werft options: