Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: remove the custom labels from the selector labels #11954

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Aug 8, 2022

Description

Remove a limitation on the custom labels by removing the customisation on the selector labels. These are "reverted" to just using the default labels function instead so they're consistent.

Related Issue(s)

Fixes #11952

How to test

Deploy via KOTS.

  1. Use a default configuration
  2. Upload a configuration as per the docs:
customization:
  - apiVersion: "*"
    kind: "*"
    metadata:
      name: "*"
      labels:
        hello: world
      annotations:
        hello: world
  1. Redeploy with the default configuration

All of these should install fine.

Release Notes

[installer]: remove the custom labels from the selector labels

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms mrsimonemms force-pushed the sje/installer-custom-labels branch from ff63f30 to e98f595 Compare August 8, 2022 12:00
@mrsimonemms mrsimonemms marked this pull request as ready for review August 8, 2022 13:10
@mrsimonemms mrsimonemms requested review from a team August 8, 2022 13:10
@github-actions github-actions bot added team: IDE team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Aug 8, 2022
@mrsimonemms
Copy link
Contributor Author

This is blocked by Go formatting issues, which is being fixed in #11958

@mrsimonemms mrsimonemms force-pushed the sje/installer-custom-labels branch from e98f595 to 48f229b Compare August 8, 2022 14:08
Copy link

@cooperbenson-qz cooperbenson-qz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for making this change!

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

Would be a good opportunity to add a test (basically a *.golden file with the result of the config you added in the PR description). What do you think?

/hold in case you want to add this

@mrsimonemms
Copy link
Contributor Author

@corneliusludmann a very good idea, I'll do that

@mrsimonemms mrsimonemms force-pushed the sje/installer-custom-labels branch from 48f229b to 186c373 Compare August 9, 2022 07:10
@roboquat roboquat added size/XXL and removed size/M labels Aug 9, 2022
@mrsimonemms
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 2fd3dd3 into main Aug 9, 2022
@roboquat roboquat deleted the sje/installer-custom-labels branch August 9, 2022 07:16
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note size/XXL team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the Installer customisation to not update the selector labels
7 participants