[dashboard] fix arbitrary useEffect #11923
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
started the job as gitpod-build-at-useeffects.1 because the annotations in the pull request description changed |
andrew-farries
approved these changes
Aug 5, 2022
|
@AlexTugarev Wanted to ask you to look into this, got a message and noticed this PR fixes it already 🤯 🦸 |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Randomly checking webapp dashboards after recent deployment shows excessive calls to newly
getSupportedWorkspaceClassesoperations caused byuseEffectwithout dependency specification, thus causing evaluation without need.Related Issue(s)
Relates to #11571
How to test
Release Notes
Documentation
Werft options: