Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixed resources #11838

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Remove fixed resources #11838

merged 1 commit into from
Aug 4, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Aug 3, 2022

Description

Remove fixed resources feature. We do not use this anymore, it is currently broken (the cpu limit annotation is applied even though it shouldn't, but it is ignored by our limiting) and it clashes with workspace classes (with #11374 limiting via annotations works again).

Related Issue(s)

n.a.

Release Notes

None

Werft options:

  • /werft with-preview

@Furisto Furisto marked this pull request as ready for review August 3, 2022 11:40
@Furisto Furisto requested a review from a team August 3, 2022 11:40
@Furisto Furisto requested review from aledbf and sagor999 as code owners August 3, 2022 11:40
@Furisto Furisto requested a review from a team August 3, 2022 11:40
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Aug 3, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! 👍

@roboquat roboquat merged commit 4b40242 into main Aug 4, 2022
@roboquat roboquat deleted the fo/fixed-resources branch August 4, 2022 09:57
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Aug 5, 2022
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XXL team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants