Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Fix project settings page #11652

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Jul 26, 2022

Description

Fix the broken dashboard settings page. Previously, changes to the checkbox settings would not be persisted.

Related Issue(s)

(internal discussion)

How to test

Toggle the checkboxes on the page, navigating between views and refreshing the page:

Screen.Recording.2022-07-26.at.13.07.41.mov

Release Notes

[dashboard] Fix persistence of checkbox values on settings page

Documentation

Werft options:

  • /werft with-preview

Ensure that when the project settings are updated, the project in the
Project context is also updated.
@andrew-farries andrew-farries requested a review from a team July 26, 2022 12:11
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 26, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-project-settings-breakage.8 because the annotations in the pull request description changed
(with .werft/ from main)

@easyCZ
Copy link
Member

easyCZ commented Jul 26, 2022

Can confirm this now works.

@roboquat roboquat merged commit 463f32e into main Jul 26, 2022
@roboquat roboquat deleted the af/project-settings-breakage branch July 26, 2022 12:31
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants