Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sign on "out of credits" #11576

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Stop sign on "out of credits" #11576

merged 1 commit into from
Aug 5, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Jul 22, 2022

Description

Partially resolves #11404

Very limited UI 🛹 of a modal shown when you've reached the configured spending limit.

Screen Shot 2022-08-03 at 14 07 02

Related Issue(s)

Related to #11404

How to test

Release Notes

Add Spending Limit Reached modal on workspace creation.

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Jul 22, 2022

/werft run

👍 started the job as gitpod-build-at-out-of-credits.2
(with .werft/ from main)

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Jul 22, 2022

/werft run

👍 started the job as gitpod-build-at-out-of-credits.3
(with .werft/ from main)

@AlexTugarev AlexTugarev force-pushed the at/out-of-credits branch 2 times, most recently from ee99a1c to 8ec9f06 Compare July 23, 2022 17:27
@AlexTugarev AlexTugarev force-pushed the at/out-of-credits branch 5 times, most recently from 4a8a0a8 to 99dfe13 Compare August 3, 2022 12:13
@AlexTugarev AlexTugarev marked this pull request as ready for review August 3, 2022 12:56
@AlexTugarev AlexTugarev requested a review from a team August 3, 2022 12:56
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 3, 2022
@geropl geropl self-assigned this Aug 4, 2022
@roboquat roboquat added size/L and removed size/M labels Aug 5, 2022
// TODO(at) replace the naive implementation based on usage service
// with a proper call check against the upcoming invoice.
// For now this should just enable the work on fronend.
if (await this.isUsageBasedFeatureFlagEnabled(user)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕺

@geropl
Copy link
Member

geropl commented Aug 5, 2022

@AlexTugarev Just noticed it requires a rebase 🙄

@roboquat roboquat merged commit bf7f1c0 into main Aug 5, 2022
@roboquat roboquat deleted the at/out-of-credits branch August 5, 2022 15:09
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paywall + Notification UI
3 participants