Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find authorized user for GHE prebuilds #11570

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Fix find authorized user for GHE prebuilds #11570

merged 1 commit into from
Aug 1, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Jul 22, 2022

Description

Iterate of team owners to find the authorized user to trigger a prebuild for a project on a push event.

Related Issue(s)

Based on: #11584

Fixes #11566

How to test

Release Notes

Fix broken prebuild trigger for GHE.

Documentation

Werft options:

  • /werft with-preview

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-at-ghe-fix.1 because the annotations in the pull request description changed
(with .werft/ from main)

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and works nicely! 🎉
image

@AlexTugarev AlexTugarev marked this pull request as ready for review August 1, 2022 07:47
@AlexTugarev AlexTugarev requested a review from a team August 1, 2022 07:47
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 1, 2022
@AlexTugarev AlexTugarev marked this pull request as draft August 1, 2022 07:47
@AlexTugarev
Copy link
Member Author

@geropl, I've seen you added ff83a64 to this branch.

Is this relevant for this PR? If not, let's remove it, it seems to be unrelated.

@geropl
Copy link
Member

geropl commented Aug 1, 2022

@AlexTugarev It's already on master, you can remove. I needed it to be able to test in the preview env.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again ✔️

@roboquat roboquat merged commit 532960e into main Aug 1, 2022
@roboquat roboquat deleted the at/ghe-fix branch August 1, 2022 09:53
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 2, 2022
@mrsimonemms mrsimonemms mentioned this pull request Aug 3, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prebuilds for GHE are not authorized for non-owner commits
3 participants