[installer]: add secret template to certs #11524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run publish-to-kots 👍 started the job as gitpod-build-sje-cert-manager-update.1 |
mrsimonemms
force-pushed
the
sje/cert-manager-update
branch
from
e43d726 to
afb11a6
Compare
|
/werft run publish-to-kots 👍 started the job as gitpod-build-sje-cert-manager-update.3 |
mrsimonemms
force-pushed
the
sje/cert-manager-update
branch
from
afb11a6 to
4677847
Compare
added 2 commits
July 21, 2022 10:03
This introduces the `secretTemplate` parameter
This allows them to be picked up by the KOTS support bundle
mrsimonemms
force-pushed
the
sje/cert-manager-update
branch
from
4677847 to
7aab955
Compare
|
/werft run publish-to-kots 👍 started the job as gitpod-build-sje-cert-manager-update.6 |
github-actions
bot
added
team: delivery
Pothulapati
approved these changes
Jul 21, 2022
|
started the job as gitpod-build-sje-cert-manager-update.7 because the annotations in the pull request description changed |
Furisto
approved these changes
Jul 21, 2022
|
Tested that labels have been applied to the certificates and I do not see any adverse effects this would have on workspace components. |
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The support bundle secret collector looks for a label
app=gitpod. As of v1.5, cert-manager supports asecretTemplateoption on the certs which adds a label and/or annotation to the secrets - NB I haven't updated to latest version of cert-manager as that requires a change of name and lots of updates to packages, including a Helm one that would require renaming the internal charts to lower case valuesThis upgrades cert-manager to latest (included renaming the package), adds the labels to the secret and configures the
secretTemplate. As this is still cert-manager v1, this does not seems to introduce any regressions and have tested both upgrades and fresh installs.The reason for this change is because I was helping a Discord user debug a cert issue and had no way of knowing if the cert had been created from the support bundle. This solves this issue by included the secret metadata in the support bundle
How to test
Install via KOTS or Installer and check for
app: gitpodin the secret's labelsRelease Notes
Documentation
Werft options: