[local-preview] Differentiate btw Gitpod starting and running
#11260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team: delivery
roboquat
added
size/XS
release-note
and removed
do-not-merge/release-note-label-needed
labels
|
started the job as gitpod-build-tar-local-preview-op.1 because the annotations in the pull request description changed |
Pothulapati
force-pushed
the
tar/local-preview-op
branch
from
a7dc636 to
bbad17b
Compare
Currently, It takes a while before Gitpod is ready even though the status says `Gitpod is running` as its not checking for readyness. This PR updates the output to separate btw `starting` and `running`. `Gitpod is running` message is showed only when we see that the `gitpod-telemetry-init` job has run which happens when all pods are ready. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tar/local-preview-op
branch
from
bbad17b to
0278789
Compare
Pothulapati
commented
Jul 11, 2022
| @@ -23,7 +23,7 @@ var msgs = []struct { | |||
| {Msg: "preparing system", Success: "extracting images to download ahead"}, | |||
| {Msg: "downloading images", Success: "--output-split-files"}, | |||
| {Msg: "preparing Gitpod preview installation", Success: "rm -rf /var/lib/rancher/k3s/server/manifests/gitpod"}, | |||
| {Msg: "starting k3s", Success: "ws-proxy"}, | |||
There was a problem hiding this comment.
I think k3s is an implementation detail that we don't have to show it to the user here
mrsimonemms
approved these changes
Jul 11, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, It takes a while before Gitpod is ready even though
the status says
Gitpod is runningas its not checking forreadyness.
This PR updates the output to separate btw
startingandrunning.Gitpod is runningmessage is showed only when we see thatthe
gitpod-telemetry-initjob has run which happens whenall pods are ready.
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #11259
How to test
Release Notes
Documentation
Werft options: