[preview] run the telemetry job right after gitpod is ready #11077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
force-pushed
the
tar/preview-tel-init
branch
from
eb9f9c0 to
ddaa3f8
Compare
Pothulapati
force-pushed
the
tar/preview-tel-init
branch
from
ddaa3f8 to
8609acc
Compare
corneliusludmann
approved these changes
Jul 4, 2022
This PR updates the `entry-point.sh` to run a parallel step
that waits for the gitpod pods to be ready, and manually executes
the cronjob once its necessary.
This is necessary as our telemetry `cronjobs` are only ran
daily in the midnight, and we can't expect this schedule to work
for local previews as they are short lived.
example data that we get:
```
client.Track(&analytics.Track{
UserId: "334c379a-afee-4882-ba44-fbd7dfc0a8b0",
Event: "Installation telemetry",
Properties: map[string]interface{}{
"customerID": "",
"platform": "local-preview",
"totalInstances": 0,
"totalUsers": 0,
"totalWorkspaces": 0,
"version": "tar-preview-tel-init.4",
},
})
```
Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tar/preview-tel-init
branch
5 times, most recently
from
4213ad8 to
1661885
Compare
|
Also, Ignore the added changes. |
|
Great! Feel free to remove the hold label when you are ready to merge. |
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this pull request
Jul 8, 2022
While #11077 adds a way to send telemetry once a `local-preview` instance is instantiated and is running, The user data is not very useful here as the user hasn't performed any actions, etc. This data is only useful right now to know that a new install has been performed. This PR updates the `local-preview` to also do the same whenever a exit signal is created, By doing this we also get the same data once a instance is being closed and hence giving use anonymous info on the usage. Signed-off-by: Tarun Pothulapati <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
entry-point.shto run a parallel stepthat waits for the gitpod pods to be ready, and manually executes
the cronjob once its necessary.
This is necessary as our telemetry
cronjobsare only randaily in the midnight, and we can't expect this schedule to work
for local previews as they are short lived.
example data that we get:
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #11113
How to test
Check if there is a new job called
gitpod-telemetry-initis created oncegitpod pods are ready.
Release Notes
Documentation
Werft options: