[kots]: add registry to preflight and support checks #11056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/kots-registry-check
branch
6 times, most recently
from
6a2b960 to
983a292
Compare
mrsimonemms
force-pushed
the
sje/kots-registry-check
branch
3 times, most recently
from
b604a93 to
cf9a04a
Compare
mrsimonemms
force-pushed
the
sje/kots-registry-check
branch
2 times, most recently
from
61b3502 to
caedb60
Compare
This checks a connection can be made, based upon the configuration given.
mrsimonemms
force-pushed
the
sje/kots-registry-check
branch
from
caedb60 to
1e35438
Compare
|
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-sje-kots-registry-check.17 |
|
This is so useful!! Thanks for adding! 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a preflight and support checks to KOTS. As with the storage and database, this uses a container for this job. This extends the storage check so that the S3 backend can be checked as well
This uses Heroku's Docker Registry Client to check the validity of the credentials. I've looked through the source code and, whilst it's not what we're using in the Image Builder, it's a much simpler structure than used elsewhere in the project. From what I could see, we'd have to write (and therefore maintain) a credential checker as I've not found that exact operation in our existing codebase. It does seem to work as expected for all the registries I've checked (Azure, GCP).
The GCP URLs add in a custom check to ensure that they're using the correct server address. This is two-fold:
gcr.io/project/repo, but uses the credentials if ongcr.ioIt's arguably a bit of a hacky approach (I'm open to suggestions), but it does work for our needs.
As with all the preflight checks, they don't prevent the user from deploying but are there to highlight whether it'll work or not. Whilst we shouldn't get any false negatives, the risk is low.
Related Issue(s)
Fixes #10337
How to test
Deploy to a cluster and run tests against the config prefligths
Release Notes
Documentation
Werft options: