Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usage] Refactor credit calculation into a WorkspacePricer #11032

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jun 30, 2022

Description

As part of #10985, we need to compute Credit cost differently for different WorkspaceClasses. This refactor keeps the existing behavour the same, but allows us to extend it to specify cost per class differently.

In subsequent PRs, the cost will be made configurable through config (eventually it may move to DB as well).

Related Issue(s)

Fixes #

How to test

Unit tests

Release Notes

NONE

Documentation

NONE

Werft options:

  • /werft with-preview

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 30, 2022
@easyCZ easyCZ force-pushed the mp/usage-pricer branch from 69e5cac to 3d03c16 Compare June 30, 2022 11:15
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green, and code looks good! 🙏

@roboquat roboquat merged commit 7c567bf into main Jun 30, 2022
@roboquat roboquat deleted the mp/usage-pricer branch June 30, 2022 12:00
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants