Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ssh-gateway] improve send heartbeat and add track #10965

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Jun 28, 2022

Description

[ssh-gateway] improve send heartbeat and add track, tracking plan

Related Issue(s)

Fixes #

How to test

  1. Start a workspace
  2. connect ssh via copy/paste command
  3. open segment, monitor event ide_close_signal, it will be send if you close ssh connect.
  4. connect ssh via copy/paste command but not require pty
# you can use ssh shell command, like

ssh 'workspaceId#ownerToken@workspaceId.ssh.ws.pd-ssh-improve-hb.preview.gitpod-dev.com' echo test
  1. monitor segment event ide_close_signal, it not send

Release Notes

SSH Gateway will send heartbeat only user explicitly request pty

Documentation

Werft options:

  • /werft with-preview
  • /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@iQQBot iQQBot force-pushed the pd/ssh-improve-hb branch from 3adebed to 2dd0a29 Compare June 28, 2022 09:13
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pd-ssh-improve-hb.3 because the annotations in the pull request description changed
(with .werft/ from main)

@iQQBot iQQBot force-pushed the pd/ssh-improve-hb branch from f8d4182 to b50b273 Compare June 28, 2022 10:17
@iQQBot iQQBot marked this pull request as ready for review June 28, 2022 10:47
@iQQBot iQQBot requested a review from a team June 28, 2022 10:47
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 28, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pd-ssh-improve-hb.6 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pd-ssh-improve-hb.7 because the annotations in the pull request description changed
(with .werft/ from main)

@iQQBot iQQBot force-pushed the pd/ssh-improve-hb branch from b50b273 to 2dd0a29 Compare June 28, 2022 10:57
@akosyakov akosyakov requested a review from mustard-mh June 28, 2022 11:15
@roboquat roboquat merged commit 1361d22 into main Jun 28, 2022
@roboquat roboquat deleted the pd/ssh-improve-hb branch June 28, 2022 13:39
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test both works

for pty
image

for shell is not send

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants