Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] enable the volume snapshot controller when the VolumeSnapshot CRD exists #10955

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jun 28, 2022

Description

For self-hosted, the VolumeSnapshot is optional for now, we should enable the volume_snapshot_controller only when the VolumeSnapshot CRD exists.

Related Issue(s)

Related to #10887
https://gitpod.slack.com/archives/C01KLC56NP7/p1656394622810719?thread_ts=1656366685.819199&cid=C01KLC56NP7

How to test

  1. Scale down the volume snapshot controller.
    kubectl scale --replicas=0 deploy/snapshot-controller -n kube-system
  2. Delete the VolumeSnapshot/VolumeSnapshotContent/VolumeSnapshotClass CRDs.
    kubectl delete vsclass --all
    kubectl delete crds volumesnapshotclasses.snapshot.storage.k8s.io
    kubectl delete crds volumesnapshots.snapshot.storage.k8s.io
    kubectl delete crds volumesnapshotcontents.snapshot.storage.k8s.io
  3. Restart the ws-manager, and make sure the ws-manager is able to start.
    kubectl rollout restart deploy/ws-manager
    kubectl rollout status deploy/ws-manager
    kubectl get pod -l component=ws-manager

Release Notes

[experimental] enable the volume snapshot controller when the VolumeSnapshot CRD exists

Documentation

N/A

Werft options:

  • /werft with-preview

@jenting jenting requested a review from a team June 28, 2022 06:58
@jenting
Copy link
Contributor Author

jenting commented Jun 28, 2022

/hold

@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 28, 2022
@jenting
Copy link
Contributor Author

jenting commented Jun 28, 2022

/unhold

@Pothulapati
Copy link
Contributor

Pothulapati commented Jun 28, 2022

/werft run publish-to-kots

👍 started the job as gitpod-build-jenting-ws-manager-check-volumesnapshotcrd.2
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented Jun 28, 2022

/werft run publish-to-kots with-clean-slate-deployment

👍 started the job as gitpod-build-jenting-ws-manager-check-volumesnapshotcrd.3
(with .werft/ from main)

@mrsimonemms mrsimonemms mentioned this pull request Jun 28, 2022
4 tasks
@mrsimonemms mrsimonemms self-requested a review June 28, 2022 10:17
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that this works in the June release on a self-hosted cluster

@roboquat roboquat merged commit 3da5e35 into main Jun 28, 2022
@roboquat roboquat deleted the jenting/ws-manager-check-volumesnapshotcrd branch June 28, 2022 11:23
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants