Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[installer]: allow docker-registry customization #10949

Merged
merged 2 commits into from
Jun 28, 2022
Merged

[installer]: allow docker-registry customization #10949

merged 2 commits into from
Jun 28, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Jun 27, 2022 •
edited
Loading

Description

Configure customization in the Helm container registry.

Related Issue(s)

Fixes #10966
Fixes #10967

How to test

Add a customization YAML such as below:

customization:
  - apiVersion: apps/v1
    kind: Deployment
    metadata:
      name: docker-registry # Important - the component name is "docker-registry"
      annotations:
        hello: world
      labels:
        hello2: world2
    spec:
      env:
        - name: hello3
          value: world3

Release Notes

[installer]: allow docker-registry customization

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Jun 27, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@lucasvaltl as a 🛹, I'm thinking of just submitting this PR with only the registry configured for customizations. My reasoning is that the only people we currently need to support are enterprises who use AWS - anyone using the in-cluster DB and object storage are unlikely to be an enterprise and therefore extremely unlikely to need customization of the components.

Are you happy with that as first stage and then adding the additional work at a future date?

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Jun 27, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run no-preview

👍 started the job as gitpod-build-sje-helm-customization.1
(with .werft/ from main)

@mrsimonemms mrsimonemms force-pushed the sje/helm-customization branch from 51d566f to deeb619 Compare June 28, 2022 09:30
@mrsimonemms mrsimonemms marked this pull request as ready for review June 28, 2022 09:31
@mrsimonemms mrsimonemms requested a review from a team June 28, 2022 09:31
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jun 28, 2022
@mrsimonemms mrsimonemms force-pushed the sje/helm-customization branch from deeb619 to 0ce2ade Compare June 28, 2022 09:35
@mrsimonemms mrsimonemms mentioned this pull request Jun 28, 2022
Merged
4 tasks
nandajavarma
nandajavarma approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@nandajavarma nandajavarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! :shipit:

@roboquat roboquat merged commit 20aca36 into main Jun 28, 2022
@roboquat roboquat deleted the sje/helm-customization branch June 28, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandajavarma nandajavarma nandajavarma approved these changes

Assignees
No one assigned
Labels
release-note size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker Registry Create Helm functions in that extend the customization functions to Helm-specific format
3 participants
@mrsimonemms @nandajavarma @roboquat