Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots]: apply customization file to Installer #10911

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Jun 24, 2022

Description

Adds the config section to the KOTS dashboard for the customization file

NB this must be applied to a cluster which does not have Gitpod installed. If you have it installed, you must run helm un -n gitpod gitpod beforehand if you intend to change any labels with your customization file. This is because Kubernetes cannot change the labels of a deployment/daemonset/statefulset. As this is for a specific set of enterprise customers who have engaged us for support, this should be an acceptable compromise for the time being.

This may be fixed in a future PR.

This is not an issue if changing annotations

Related Issue(s)

Fixes #10910

How to test

Deploy via KOTS to a cluster, using this YAML as your customization file

customization:
  - apiVersion: apps/v1
    kind: Deployment
    metadata:
      name: server
      annotations:
        hello: world

When you next run it, kubectl get pods -n gitpod -l component=server -o jsonpath="{.items[0].metadata.annotations}" should have the annotation hello=word

Release Notes

[kots]: apply customization file to Installer

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms mrsimonemms force-pushed the sje/kots-customization branch 2 times, most recently from f3dbb40 to 7c20554 Compare June 27, 2022 10:15
@mrsimonemms mrsimonemms marked this pull request as ready for review June 27, 2022 10:15
@mrsimonemms mrsimonemms requested a review from a team June 27, 2022 10:15
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jun 27, 2022
Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment. Feel free to address and merge it.

/hold

install/kots/manifests/kots-config.yaml Outdated Show resolved Hide resolved
@mrsimonemms mrsimonemms force-pushed the sje/kots-customization branch from 7c20554 to a13b178 Compare June 27, 2022 10:36
@roboquat roboquat added size/M and removed size/S labels Jun 27, 2022
@mrsimonemms
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit b21e31a into main Jun 27, 2022
@roboquat roboquat deleted the sje/kots-customization branch June 27, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure KOTS input
3 participants