Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bridge] Add log.error in case we are about to override a previous "failed" condition #10900

Merged
merged 1 commit into from
Jun 24, 2022
Merged

[bridge] Add log.error in case we are about to override a previous "failed" condition #10900

merged 1 commit into from
Jun 24, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jun 24, 2022 •
edited
Loading

Description

1 of 2 PRs that attempt to fix the bug described in #8596
Explanation: #8596 (comment)

Related Issue(s)

Context: #8596

How to test

  • start a workspace
  • see that everything works as expected
  • check ws-manager-bridge logs and search for "We received an empty "failed" condition overriding an existing one"

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@geropl geropl requested a review from a team June 24, 2022 12:48
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 24, 2022
@geropl geropl mentioned this pull request Jun 24, 2022
Closed
@geropl
Copy link
Member Author

geropl commented Jun 24, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-gpl-8596-failed.2
(with .werft/ from main)

easyCZ
easyCZ approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also consider using metrics for that.

/hold

@geropl
Copy link
Member Author

geropl commented Jun 24, 2022

You could also consider using metrics for that.

I agree. I'm not sure about how big this is of a problem, at all, and want to look at examples to get an idea what kind of bug this is. Let's reconsider again, then. 👍

@geropl
Copy link
Member Author

geropl commented Jun 24, 2022

/unhold

@roboquat roboquat merged commit d9bf64f into main Jun 24, 2022
@roboquat roboquat deleted the gpl/8596-failed branch June 24, 2022 12:58
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geropl @easyCZ @roboquat