[db] fix adminGetWorkspaces/findAllWorkspaceAndInstances #10825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-at-fix-admingetworkspaces.1 |
|
/werft run with-preview 👍 started the job as gitpod-build-at-fix-admingetworkspaces.2 |
geropl
reviewed
Jun 24, 2022
| @@ -1048,7 +1048,7 @@ export abstract class AbstractTypeORMWorkspaceDBImpl implements WorkspaceDB { | |||
| .createQueryBuilder("ws") | |||
| // We need to put the subquery into the join condition (ON) here to be able to reference `ws.id` which is | |||
| // not possible in a subquery on JOIN (e.g. 'LEFT JOIN (SELECT ... WHERE i.workspaceId = ws.id)') | |||
| .leftJoinAndMapOne( | |||
| .innerJoinAndMapOne( | |||
There was a problem hiding this comment.
Have my upvote for super-power one-line fix 💪 🦸
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a SQL query bug in the admin dashboard, which causes to return an empty page instead the list of a user's workspaces.
How to test
Verify that workspaces are shown as expected in the admin panel.
Release Notes
Documentation
Werft options: