remove core-dev preview environment options

[liam-j-bennett]

Description

Removes the core-dev preview environment options

Related Issue(s)

Fixes #2529

Release Notes

NONE

Werft options:

• /werft with-preview

[liam-j-bennett]

/release-note-none

[meysholdt]

hi @liam-j-bennett!
It's great to see how much simpler our code becomes - can you remove core-dev-related code from the cleanup job as well? see here.

[werft-gitpod-dev-com]

started the job as gitpod-build-ljb-2529-remove-core-dev-preview-env.1 because the annotations in the pull request description changed
(with .werft/ from main)

[ArthurSens]

Nice clean-up 🧹!

Just like mo said, I believe we can clean up even more! I think we can also un-mount some secrets from .werft/build.yaml and also delete some terraform code that creates those secrets(terraform would be another PR in another repo of course 🙂)

[ArthurSens]

LGTM!

I see that we have a hold label in place, so I'm already approving because the PR solves the problem: "Discontinue previews in core-dev" 🙂

Just wanted to remind the team of another problem that we still have which is getting rid of pieces of infrastructure required to run previews in core-dev. Things that come to my mind:

• Secrets in .werft/build.yaml
• Terraform code for those same secrets

But there might be more 😬

[meysholdt]

This looks great already! I found one line that looks like it should be deleted, too and two nits. See comments.

[meysholdt]

🚀 🚀 🚀

[meysholdt]

Thx for updating the PR! The code changes LGTM, but I see the build failing via:

Error Error: kubectl --kubeconfig /workspace/gitpod/kubeconfigs/k3s apply -f k8s.yaml exit with non-zero status code.
The Job "migrations" is invalid: spec.template: Invalid value:... (there are more details in the log)

[meysholdt]

After taking a second look, I think two of the secrets are still in use.

[liam-j-bennett]

Regarding the build error:

        this.options.werft.log(slice, "Installing Gitpod");
        exec(`kubectl --kubeconfig ${this.options.kubeconfigPath} delete -n ${this.options.deploymentNamespace} job migrations || true`, { silent: true });
        // errors could result in outputing a secret to the werft log when kubernetes patches existing objects...
        exec(`kubectl --kubeconfig ${this.options.kubeconfigPath} apply -f k8s.yaml`, { silent: true });

Is the delete failing somehow? We ignore all errors, not just the NotFound

[liam-j-bennett]

Build issue seems to have fixed itself

[meysholdt]

🚀 🚀 🚀