[ws-daemon] Fix quota size regex's false positives

[CuriousCorrelation]

Description

I found this while browsing the repo

gitpod/components/ws-daemon/pkg/quota/size_test.go

Lines 26 to 27 in d114f03

	// This test should fail but doesn't because match somehow matches the regexp
	// {"-42m", 0, quota.ErrInvalidSize},

-42m works because the regex correctly matched on the 42m part, see https://regexr.com/6o0va

so does this

{"-42m", 42 * quota.Megabyte, nil},
{"ab-42mcd", 42 * quota.Megabyte, nil},

Quick fix is to constrain starting and ending characters, i.e.

^(\d+)(k|m|g|t)?$

How to test

This test now succeeds

gitpod/components/ws-daemon/pkg/quota/size_test.go

Line 15 in d114f03

func TestParseSize(t *testing.T) {

Release Notes

Fixed quota size regex allowing false positives

[Furisto]

/werft run

👍 started the job as gitpod-build-fix-quota-regex-fork.0
(with .werft/ from main)

[Furisto]

Thank you @CuriousCorrelation