-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.gitpod.yml generator] Use 'pnpm' package manager when there is a pnpm-lock.yaml file or the package.json specifies it #10731
Conversation
Hint: Reviewing without whitespace changes is easier: https://github.com/gitpod-io/gitpod/pull/10731/files?w=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test for this to config-inferrer.spec.ts
too.
Is there easy way mock ctx for now ? |
@gengjiawen Yes, something like this is already set up here: https://github.com/gitpod-io/gitpod/blob/main/components/server/src/config/config-inferrer.spec.ts FYI, given that I'll be on holidays for a few weeks -- please feel free to re-appropriate my PR and add a test to the |
@jankeromnes friendly ping |
…k.yaml file or the package.json specifies it Co-authored-by: Jiawen Geng <[email protected]>
New tests run and pass:
|
Description
When auto-generating a
.gitpod.yml
, look for apnpm-lock.yaml
file in the root of the repository, or apackageManager
entry inpackage.json
that starts with"pnpm"
. If it's a match, the wanted package manager is likelypnpm
(instead ofnpm
oryarn
).Related Issue(s)
Fixes #10374
How to test
pnpm
(which does not yet have a committed.gitpod.yml
) in the preview environment.gitpod.yml
should usepnpm
(instead ofnpm
oryarn
)Release Notes
Documentation