Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update env to use werft grpc #10730

Merged
merged 3 commits into from
Jun 21, 2022
Merged

update env to use werft grpc #10730

merged 3 commits into from
Jun 21, 2022

Conversation

liam-j-bennett
Copy link
Contributor

Description

Update env in the dev Dockerfile to use the werft gRPC API

Related Issue(s)

Fixes #2083

Release Notes

NONE

@roboquat roboquat added size/S and removed size/XS labels Jun 17, 2022
@liam-j-bennett
Copy link
Contributor Author

/release-note-none

@liam-j-bennett liam-j-bennett marked this pull request as ready for review June 17, 2022 12:05
@liam-j-bennett liam-j-bennett requested review from a team June 17, 2022 12:05
@github-actions github-actions bot added team: IDE team: devx team: workspace Issue belongs to the Workspace team labels Jun 17, 2022
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test it?

@roboquat roboquat removed the size/S label Jun 17, 2022
@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@liam-j-bennett
Copy link
Contributor Author

Should we test it?

I run the below in a workspace and werft still works:

export WERFT_CREDENTIAL_HELPER=/workspace/gitpod/dev/preview/werft-credential-helper.sh
export WERFT_HOST=werft-grpc.gitpod-dev.com:443
export WERFT_TLS_MODE=system
werft job list
NAME                                                                OWNER                  REPO                    PHASE             SUCCESS
local-wulfthimm-oily-chimp                                          Wulf Thimm             gitpod-io/gitpod        PHASE_DONE        false
local-wulfthimm-bailing-buffoon                                     Wulf Thimm             gitpod-io/gitpod        PHASE_DONE        false
local-thomasschubart-intent-flee                                    Thomas Schubart        gitpod-io/gitpod        PHASE_DONE        false
...

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Jun 17, 2022

@liam-j-bennett I added the hold label. Does the credentials helper work in Werft jobs? If it doesn't we need to update all the jobs that use the Werft CLI so that they have WERFT_K8S_NAMESPACE=werft and ENV WERFT_DIAL_MODE=kubernetes set so we don't break them ☺️

If the credentials helper works you can just remove the hold label ☺️

@liam-j-bennett
Copy link
Contributor Author

liam-j-bennett commented Jun 17, 2022

@liam-j-bennett I added the hold label. Does the credentials helper work in Werft jobs? If it doesn't we need to update all the jobs that use the Werft CLI so that they have WERFT_K8S_NAMESPACE=werft and ENV WERFT_DIAL_MODE=kubernetes set so we don't break them ☺️

If the credentials helper works you can just remove the hold label ☺️

It works in the test I used. It should be noted that auth is not enabled, so it's basically just checking it executes

@liam-j-bennett
Copy link
Contributor Author

liam-j-bennett commented Jun 21, 2022

/werft run

👍 started the job as gitpod-build-ljb-werft-cli-grpc-changes.3
(with .werft/ from main)

@roboquat roboquat merged commit 704a426 into main Jun 21, 2022
@roboquat roboquat deleted the ljb/werft_cli_grpc_changes branch June 21, 2022 09:06
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed: IDE IDE change is running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/M team: devx team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants