-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update env to use werft grpc #10730
update env to use werft grpc #10730
Conversation
/release-note-none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test it?
|
I run the below in a workspace and werft still works:
|
@liam-j-bennett I added the hold label. Does the credentials helper work in Werft jobs? If it doesn't we need to update all the jobs that use the Werft CLI so that they have If the credentials helper works you can just remove the hold label |
It works in the test I used. It should be noted that auth is not enabled, so it's basically just checking it executes |
/werft run 👍 started the job as gitpod-build-ljb-werft-cli-grpc-changes.3 |
Description
Update env in the dev Dockerfile to use the werft gRPC API
Related Issue(s)
Fixes #2083
Release Notes
NONE