[bridge] Refactor Bridge.controlInstances and add tracing (4/5) #10727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/9395-stuck-prebuilds-4
branch
4 times, most recently
from
f444050 to
59c02a3
Compare
geropl
force-pushed
the
gpl/9395-stuck-prebuilds-4
branch
from
59c02a3 to
c22d66d
Compare
geropl
commented
Jun 23, 2022
| ); | ||
|
|
||
| disconnectStarted = Number.MAX_SAFE_INTEGER; // Reset disconnect period | ||
| } catch (err) { |
There was a problem hiding this comment.
This inner try-catch is preparation for a followup PR.
geropl
commented
Jun 23, 2022
|
|
||
| const runningInstances = await this.workspaceDB.trace(ctx).findRunningInstancesWithWorkspaces(installation); |
There was a problem hiding this comment.
There are three changes in this method:
- swapped local
findRunningInstancesWithWorkspaceswith external call - added span (and thus: try-catch to finish() it)
- extraction of
markWorkspaceInstanceAsStopped
|
started the job as gitpod-build-gpl-9395-stuck-prebuilds-4.7 because the annotations in the pull request description changed |
geropl
changed the title
1 task
andrew-farries
approved these changes
Jun 24, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prepares for fixing a bug with prebuilds being stuck in
queuedindefinitely in rare cases. (4/5 in the chain)To that end, if mostly refactors the method
controlInstancesinBridge, and adds tracing to it.Related Issue(s)
Context: #9395
Follow-up: #10882
How to test
./dev/preview/install-k3s-kubeconfig.shws-manager-bridge:gpctl debug log ws-manager-bridgeRelease Notes
Documentation