-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer] Add EKS installer test #10709
Conversation
6b482f5
to
370aa01
Compare
started the job as gitpod-build-nvn-infra-eks.15 because the annotations in the pull request description changed |
b9828ea
to
518ee22
Compare
ba85e5b
to
11e92f2
Compare
10a5b0c
to
8006bc7
Compare
2ca5689
to
f40f210
Compare
8006bc7
to
679d2ca
Compare
6a096d5
to
84e477a
Compare
04f9400
to
c7a723e
Compare
84e477a
to
37a5c53
Compare
0f2d065
to
245e2ba
Compare
ca8985f
to
34dd1c4
Compare
245e2ba
to
6d59df5
Compare
dfe6d7f
to
9833a95
Compare
6d59df5
to
fb2580b
Compare
9833a95
to
ef4e766
Compare
ef4e766
to
8bbd0e7
Compare
8bbd0e7
to
37d1d6f
Compare
37d1d6f
to
cdb4580
Compare
This PR is pending approval, I've added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, blast; I had a long, throughful approval message and GitHub ate it. Here's the short version!
This is really great work, and I see the effort that you put in! This'll be really helpful for improving our developer velocity and solidifying the self hosted releases.
In short, we can ship this as is. I see some risks, outlined below, but I'm approving this and will leave any changes up to your discretion, @nandajavarma.
The following items can be optionally extracted to separate issues. Since I'm asking for the work I can pick up the issue creation and contribute fixes; let me know if you'd like support here.
Blockers
None!
Risks/recommendations
- Hardcoded database passwords: this is the kind of thing that could bite us down the road. We can hopefully drop in a terraform
random_password
resource to solve this. Would prefer if we do that before merging, can address that afterwards. - VPC ingress/egress rules: our customers are going to have more restrictive VPC rules; we'll need to prove out what's actually needed for everything to work.
Suggestions
- Factor our
terraform apply -target
: we're leaning on this feature pretty heavily and it's meant to be a niche behavior. We're likely to stretch this a little too far in the foreseeable future. We should definitely handle this one later but let's keep an eye on removing the need for targeted applies.
Small fixups
I'm still a walking spell checker 😅 Any fixups for spelling or small details are opportunistic fixes and don't impact correctness or behavior. Adjust as you see fit but don't sweat them!
Again, thanks for all of the hard work!
Updates made:
|
4f1cd2f
to
87e7f9d
Compare
87e7f9d
to
e0b8659
Compare
/unhold Letting this one in since all the review suggestions are acknowledged. |
Description
This PR adds the
EKS
terraform module for testing purposes to the repo. These are the most important updates:infra
directory - the security groups are at the moment very permissive. This can be fixed as a part of the epic to make these tf module production ready if need be.installer-test.ts
,Makefile
andmain.tf
to accommodate newEKS
test configurationeks-installer-test.yml
to trigger the cronjob for this configurationexternal-dns
andissuer
modules to be use used for bothazure
andaws
. This involves:external_dns_settings
output from aks module to supportdynamic
setting in external-dns tf module.external-dns
tocloud-dns-external-dns
(since this is only for cloud-dns - this will be cleaned up more in a future PR), renamingazure-external-dns
toexternal-dns
since this will eventually be standard across all providersRelated Issue(s)
Fixes #
How to test
To test this, get authentication to
core-dev
cluster on GCP. Then run:Release Notes
Documentation