[prebuilds] prebuild detail view in create workspace #10696

laushinka · 2022-06-16T10:29:34Z

Description

This PR gives a perceived consistency between the create workspace page and the prebuild detail view.

Related Issue(s)

How to test

Make a commit to a project with a prebuild.
Go to the project page's Branches tab. Once the prebuild is shown as "Running", start a new workspace.
See the logs running and the prebuild status showing below.

Release Notes

Prebuild status is shown under the logs when starting a workspace.

Documentation

/werft with-preview
/werft with-clean-slate-deployment

laushinka · 2022-06-21T07:52:54Z

/werft run

👍 started the job as gitpod-build-laushinka-prebuild-view-9132.12
(with .werft/ from main)

werft-gitpod-dev-com · 2022-06-21T07:52:55Z

started the job as gitpod-build-laushinka-prebuild-view-9132.11 because the annotations in the pull request description changed
(with .werft/ from main)

components/dashboard/src/start/IntermediatePrebuildStatus.tsx

geropl · 2022-06-27T07:57:00Z

This is basically done, and I'd love to approve. But as we found out above, we're missing proper resourceguards for prebuilds. So I'm going to hold this PR, and try to get it in before we land this.

/hold

geropl · 2022-06-27T16:18:08Z

Now waiting for #10940 to get merged...

gtsiolis · 2022-06-27T17:06:53Z

/werft run

👍 started the job as gitpod-build-laushinka-prebuild-view-9132.48
(with .werft/ from main)

gtsiolis · 2022-06-27T17:29:53Z

Looking at this now! 👀

gtsiolis

I never clicked submit but here's what I had in draft since yesterday. 🙈

Since we do not have yet the capability to expand the logs into a full page component, going with the current logs width sounds ok. Any thoughts on #9132 (comment)?

Two issues that pop up:

The scrollbar position mentioned in [prebuilds] prebuild detail view in create workspace #10696 (comment). Moving forward with the current scrollbar styles sounds ok but the positioning the scrollbar in the middle of the element feels like something is broken.
The width of the element wrapping the bottom parts of the prebuilds logs differ per case. Could we adjust the width of the bottom elements to match the prebuilds logs element above? See screenshots below.

Prebuild (Running)	Prebuild (Preparing)

geropl · 2022-06-29T14:57:12Z

/werft run

👍 started the job as gitpod-build-laushinka-prebuild-view-9132.50
(with .werft/ from main)

werft-gitpod-dev-com · 2022-06-29T15:34:51Z

started the job as gitpod-build-laushinka-prebuild-view-9132.51 because the annotations in the pull request description changed
(with .werft/ from main)

geropl · 2022-06-29T16:12:16Z

@gtsiolis I think I fixed it (by re-using the same horizontal spacing we had in WorkspaceLogs before). Once the build is through, do you want to re-test? 🧡

Thx @jankeromnes for the help! 🙏

Prebuild Details	Prebuild on Start-/CreateWorkspace

geropl

Tested and works! 👍

/hold in cases someone else wants to review

gtsiolis

Perfection achieved. ✨

Thanks, @geropl, @laushinka, @jldec, and @jankeromnes! 🏀

While I still think using a narrower width as described in #9132 (comment) could be interesting to explore, 🅰️ the changes here already significantly improve the current state of the prebuild-in-progress page and 🅱️ we'd still need to add a function to expand the view to a full page component which would significantly increase the scope of this PR.

Looking forward for #10041 or whatever comes next.

jankeromnes · 2022-06-29T16:46:12Z

components/dashboard/src/start/CreateWorkspace.tsx

 import CodeText from "../components/CodeText";
 import FeedbackComponent from "../feedback-form/FeedbackComponent";
 import { isGitpodIo } from "../utils";

-const WorkspaceLogs = React.lazy(() => import("../components/WorkspaceLogs"));


I wonder if PrebuildLogs should also be lazy-loaded here?

E.g. no need to load all of xTermjs if you're creating a workspace that doesn't show any logs.

Ah, good idea! But my workspace has timed out, so: let's do as a follow-up 😉

geropl · 2022-06-29T18:17:16Z

/unhold

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed size/S labels Jun 16, 2022

laushinka force-pushed the laushinka/prebuild-view-9132 branch 3 times, most recently from 8386a8f to 4ae8ffd Compare June 20, 2022 07:54

roboquat added size/M size/L and removed size/S size/M labels Jun 20, 2022

laushinka force-pushed the laushinka/prebuild-view-9132 branch from a10b043 to b6d2007 Compare June 21, 2022 07:27

laushinka force-pushed the laushinka/prebuild-view-9132 branch 5 times, most recently from eb1689a to 26b43b6 Compare June 21, 2022 22:00

roboquat added release-note and removed do-not-merge/release-note-label-needed labels Jun 21, 2022

laushinka commented Jun 21, 2022

View reviewed changes

components/dashboard/src/start/IntermediatePrebuildStatus.tsx Outdated Show resolved Hide resolved

laushinka force-pushed the laushinka/prebuild-view-9132 branch from 26b43b6 to 68eeca1 Compare June 21, 2022 22:38

laushinka marked this pull request as ready for review June 21, 2022 22:40

laushinka requested a review from a team June 21, 2022 22:40

roboquat removed the do-not-merge/work-in-progress label Jun 21, 2022

github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 21, 2022

laushinka marked this pull request as draft June 22, 2022 08:50

roboquat added the do-not-merge/work-in-progress label Jun 22, 2022

laushinka force-pushed the laushinka/prebuild-view-9132 branch 2 times, most recently from 9921c71 to 2fac644 Compare June 22, 2022 21:33

laushinka force-pushed the laushinka/prebuild-view-9132 branch from dd3199e to d2c08f3 Compare June 24, 2022 16:49

This was referenced Jun 27, 2022

Add tests for GuardedResources: Workspace, WorkspaceInstance and WorkspaceLog (1/2) #10939

Merged

Introduce GuardedPrebuild to be used in #10696 #10940

Merged

geropl marked this pull request as draft June 27, 2022 16:17

roboquat added the do-not-merge/work-in-progress label Jun 27, 2022

laushinka and others added 2 commits June 29, 2022 08:21

use prebuildlogs instead

82ca804

[server] Guard prebuild-related APIs with GuardedPrebuild resource

8f2b6c8

geropl force-pushed the laushinka/prebuild-view-9132 branch from d2c08f3 to 8f2b6c8 Compare June 29, 2022 09:23

gtsiolis reviewed Jun 29, 2022

View reviewed changes

[dashboard] Fix PrebuildLogs layout

5f80c29

geropl force-pushed the laushinka/prebuild-view-9132 branch from 72e292b to 5f80c29 Compare June 29, 2022 16:09

geropl marked this pull request as ready for review June 29, 2022 16:13

roboquat removed the do-not-merge/work-in-progress label Jun 29, 2022

geropl approved these changes Jun 29, 2022

View reviewed changes

gtsiolis approved these changes Jun 29, 2022

View reviewed changes

jankeromnes reviewed Jun 29, 2022

View reviewed changes

roboquat removed the do-not-merge/hold label Jun 29, 2022

roboquat merged commit 3133297 into main Jun 29, 2022

roboquat deleted the laushinka/prebuild-view-9132 branch June 29, 2022 18:17

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 30, 2022

gtsiolis mentioned this pull request Jul 1, 2022

Update prebuild status description alignment #11086

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[prebuilds] prebuild detail view in create workspace #10696

[prebuilds] prebuild detail view in create workspace #10696

laushinka commented Jun 16, 2022 •

edited by geropl

Loading

laushinka commented Jun 21, 2022 •

edited by werft-gitpod-dev-com bot

Loading

werft-gitpod-dev-com bot commented Jun 21, 2022

geropl commented Jun 27, 2022

geropl commented Jun 27, 2022

gtsiolis commented Jun 27, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Jun 27, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment

geropl commented Jun 29, 2022 •

edited by werft-gitpod-dev-com bot

Loading

werft-gitpod-dev-com bot commented Jun 29, 2022

geropl commented Jun 29, 2022 •

edited

Loading

geropl left a comment

gtsiolis left a comment •

edited

Loading

jankeromnes Jun 29, 2022

geropl Jun 29, 2022

geropl commented Jun 29, 2022

[prebuilds] prebuild detail view in create workspace #10696

[prebuilds] prebuild detail view in create workspace #10696

Conversation

laushinka commented Jun 16, 2022 • edited by geropl Loading

Description

Related Issue(s)

How to test

Release Notes

Documentation

laushinka commented Jun 21, 2022 • edited by werft-gitpod-dev-com bot Loading

werft-gitpod-dev-com bot commented Jun 21, 2022

geropl commented Jun 27, 2022

geropl commented Jun 27, 2022

gtsiolis commented Jun 27, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis commented Jun 27, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment

Choose a reason for hiding this comment

geropl commented Jun 29, 2022 • edited by werft-gitpod-dev-com bot Loading

werft-gitpod-dev-com bot commented Jun 29, 2022

geropl commented Jun 29, 2022 • edited Loading

geropl left a comment

Choose a reason for hiding this comment

gtsiolis left a comment • edited Loading

Choose a reason for hiding this comment

jankeromnes Jun 29, 2022

Choose a reason for hiding this comment

geropl Jun 29, 2022

Choose a reason for hiding this comment

geropl commented Jun 29, 2022

laushinka commented Jun 16, 2022 •

edited by geropl

Loading

laushinka commented Jun 21, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Jun 27, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Jun 27, 2022 •

edited by werft-gitpod-dev-com bot

Loading

geropl commented Jun 29, 2022 •

edited by werft-gitpod-dev-com bot

Loading

geropl commented Jun 29, 2022 •

edited

Loading

gtsiolis left a comment •

edited

Loading