Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PVC support to prebuilds #10689

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Add PVC support to prebuilds #10689

merged 1 commit into from
Jun 24, 2022

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented Jun 15, 2022

Description

This PR adds support for PVC to prebuilds.
You can now enable PVC in your project settings, and all prebuilds going forward will use PVC and backup prebuild result into Volume Snapshot. When you open workspace from such prebuild, it will automatically opt in into using PVC feature.
Prebuilds using PVC can only be opened using PVC feature.
If something is not working or broken, you just disable that option in project setting and trigger a new prebuild to use old method.

Opening workspace from a prebuild that contains a lot of data should be much faster when using PVC.

Related Issue(s)

Fixes #10260

How to test

  1. Open preview environment
  2. Add your project.
  3. Go into project settings and enable PVC feature flag.
  4. Trigger new prebuild.
  5. Open workspace from that prebuild.

For extra points:
Enable incremental prebuilds, and observe that this works correctly with PVC feature enabled as well.

Release Notes

none

Documentation

Werft options:

  • /werft with-preview

@sagor999
Copy link
Contributor Author

sagor999 commented Jun 20, 2022

/werft run with-clean-slate-deployment=true with-preview=true

👍 started the job as gitpod-build-pavel-10260.23
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pavel-10260.25 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Jun 21, 2022
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thank you

@laushinka
Copy link
Contributor

laushinka commented Jun 24, 2022

/werft run

👍 started the job as gitpod-build-pavel-10260.29
(with .werft/ from main)

@laushinka laushinka self-assigned this Jun 24, 2022
@sagor999
Copy link
Contributor Author

sagor999 commented Jun 24, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-pavel-10260.30
(with .werft/ from main)

@laushinka
Copy link
Contributor

Tested - starting workspace and prebuild logs look good with and without the PVC setting.

LGTM

@roboquat roboquat merged commit 7d00501 into main Jun 24, 2022
@roboquat roboquat deleted the pavel/10260 branch June 24, 2022 16:52
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prebuilds: add support for using PVC\VolumeSnapshots to prebuilds.
4 participants