-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PVC support to prebuilds #10689
Add PVC support to prebuilds #10689
Conversation
/werft run with-clean-slate-deployment=true with-preview=true 👍 started the job as gitpod-build-pavel-10260.23 |
started the job as gitpod-build-pavel-10260.25 because the annotations in the pull request description changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, thank you
/werft run 👍 started the job as gitpod-build-pavel-10260.29 |
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-pavel-10260.30 |
Tested - starting workspace and prebuild logs look good with and without the PVC setting. LGTM |
Description
This PR adds support for PVC to prebuilds.
You can now enable PVC in your project settings, and all prebuilds going forward will use PVC and backup prebuild result into Volume Snapshot. When you open workspace from such prebuild, it will automatically opt in into using PVC feature.
Prebuilds using PVC can only be opened using PVC feature.
If something is not working or broken, you just disable that option in project setting and trigger a new prebuild to use old method.
Opening workspace from a prebuild that contains a lot of data should be much faster when using PVC.
Related Issue(s)
Fixes #10260
How to test
For extra points:
Enable incremental prebuilds, and observe that this works correctly with PVC feature enabled as well.
Release Notes
Documentation
Werft options: