[dashboard] introduce folded inactive ws section #10676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
sefftinge/make-it-easier-to-delete-4233
branch
from
9e9bb32 to
2ab49f3
Compare
|
started the job as gitpod-build-sefftinge-make-it-easier-to-delete-4233.19 because the annotations in the pull request description changed |
AlexTugarev
reviewed
Jun 15, 2022
| @@ -37,6 +37,9 @@ export default function Modal(props: { | |||
| .catch(console.error); | |||
| }; | |||
| const handler = (evt: KeyboardEvent) => { | |||
| if (!props.visible) { | |||
gtsiolis
reviewed
Jun 15, 2022
There was a problem hiding this comment.
UX LGTM. ✔️
@svenefftinge This probably resolves also #10662, right?
|
started the job as gitpod-build-sefftinge-make-it-easier-to-delete-4233.20 because the annotations in the pull request description changed |
AlexTugarev
approved these changes
Jun 15, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reapplies the changes from the previously reverted PR #10450 and fixes
Description
Many users are manually deleting workspaces, keeping their workspaces list clean.
Users should feel less urge to manually clean up and cleaning up should be simpler.
This PR, makes the inactive workspaces section on the /workspaces list collapsable (collapsed by default) to give a cleaner impression. When expanded there is a button to delete them.
Related Issue(s)
Fixes #10662
Fixes #10665
Fixes #1053
Fixes #4233
How to test
Use the preview env and start a few workspaces, stop them. Check the workspaces list.
Release Notes
Documentation