-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[content-service] Use gsutil to upload and download backups #10626
Conversation
aa2b0c6
to
57835db
Compare
137a5c5
to
52b0111
Compare
5908dc8
to
293c1d4
Compare
args := fmt.Sprintf(`gsutil -q -m %v\ | ||
-o "GSUtil:parallel_composite_upload_threshold=150M" \ | ||
-o "GSUtil:parallel_process_count=3" \ | ||
-o "GSUtil:parallel_thread_count=6" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the parameter as now or should we limit more CPU resources for gsutil?
We have already limited the number of simultaneous backups to three. Also, the trade-off we are doing here is less RAM and better transfer speeds with more CPU utilization (short period of time).
That said if you have an idea to improve this, please post it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to use https://github.com/EmbarkStudios/gsutil. That should consume fewer resources, but I could get it working consistently.
I think this change deserve a release note. Code LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It works on gen51 and is working charming.
Description
Switch to gcloud gsutil cli to upload and downloads for GCS interaction with backups. This improves the speed and also removes the multipart complexity from the codebase.
Release Notes