-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistent volume claim to prebuild settings #10539
Conversation
Hey @sagor999, this is a great use-case for FeatureFlags we've recently introduced. We've not got too much in the way of write up for this so I'm happy to pair initially to bring you up to speed. I'll then use this as the basis for some write-up to make it a bit more self-serve. Let me know when you're free or drop something in my calendar. You can also have a look at existing usage in https://github.com/gitpod-io/gitpod/blob/main/components/dashboard/src/Menu.tsx#L164-L182 |
@easyCZ PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage of the feature flag looks good to me, and in general PR looks good. I'm no expert in React however. Adding hold in case you want to get a review from someone else as well.
/hold
@jankeromnes would you be able to take a look at React portion? |
@sagor999 Did you think about replacing that project-level config with a feature-flag entirely? 🤔 Or is it that you really want to expose this option to users? 🤔 |
@geropl yes, I would like it being exposed to users, as we will slowly start offering this to some of our SaaS customers to try it out, if we think it will be a great benefit to them and they are willing to test it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, and works!
/unhold |
Description
This adds setting to prebuilds to enable support for persistent volume claims.
Made sure to add a warning to let users know to not enable this setting, but I am open for a better alternative\text or if there is way to gate this feature to gitpod only for now.
This is how it would look:
Related Issue(s)
Related: #10260
How to test
Launch preview env, add your project to it and navigate to settings.
Release Notes
Documentation