Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JetBrains Gateway Plugin to work on v222.2889.2 #10505

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Fix JetBrains Gateway Plugin to work on v222.2889.2 #10505

merged 1 commit into from
Jun 7, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Jun 7, 2022 •
edited
Loading

Description

Add parameters to ConnectionBuilder constructor, as on the next Gateway release it won't run without them.

Related Issue(s)

None.

How to test

Note: This can only be tested by Gitpod Team, with access to the non-released version of JetBrains Gateway.

  • Download JetBrains Gateway v222.2889.2 for Mac and install it.
  • Install the Gitpod's gateway-plugin from the JetBrains Gateway home screen.
    image
  • Connect to any workspace and confirm you're getting the following error when clicking 'Connect' button from the Gateway workspaces list.
    image
  • Uninstall the gateway-plugin.
  • Download the gateway-plugin build from this PR from here and install it on the Gateway.
  • Connect to the same workspace and confirm if now you don't get any error while connecting.

Release Notes

Fix JetBrains Gateway Plugin to work on v222.2889.2

Documentation

  • /werft --no-preview=true

@felladrin felladrin requested a review from a team June 7, 2022 15:10
@felladrin felladrin self-assigned this Jun 7, 2022
@andreafalzetti
Copy link
Contributor

I followed the steps and it works as advertised!

Good job!

@roboquat roboquat merged commit be105da into main Jun 7, 2022
@roboquat roboquat deleted the vn/fix-gateway-plugin-not-working-on-next-eap branch June 7, 2022 21:45
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jun 9, 2022
@felladrin felladrin mentioned this pull request Jun 10, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreafalzetti andreafalzetti andreafalzetti approved these changes

Assignees

@felladrin felladrin

Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/XS team: IDE
Projects
🚀 IDE Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felladrin @andreafalzetti @roboquat